fix(attribute): treat null like undefined

jcoreio · Feb 9, 2021 · 7465a62 · 7465a62
1 parent 8952388
commit 7465a62
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/assertions/attribute.js b/src/assertions/attribute.js
@@ -24,7 +24,7 @@ const attribute = (client, chai, utils, options) =>
         elements.map(async element => {
           const value = await element.getAttribute(attribute)
           values.push(value)
-          return value !== undefined
+          return value != null
         })
       )).filter(Boolean)
 

diff --git a/test/assertions/attribute-test.js b/test/assertions/attribute-test.js
@@ -67,7 +67,7 @@ describe('attribute', () => {
 
     beforeEach(() => {
       fakeElement1.getAttribute.withArgs('foo').resolves(elementAttribute)
-      fakeElement1.getAttribute.withArgs('bar').resolves(undefined)
+      fakeElement1.getAttribute.withArgs('bar').resolves(null)
       fakeClient.$$.withArgs('.some-selector').resolves([fakeElement1])
     })
 
@@ -168,9 +168,9 @@ describe('attribute', () => {
       fakeElement1.getAttribute.resolves(elementAttribute1)
       fakeElement2.getAttribute.resolves(elementAttribute2)
       fakeElement1.getAttribute.withArgs('foo').resolves(elementAttribute1)
-      fakeElement1.getAttribute.withArgs('bar').resolves(undefined)
+      fakeElement1.getAttribute.withArgs('bar').resolves(null)
       fakeElement2.getAttribute.withArgs('foo').resolves(elementAttribute2)
-      fakeElement2.getAttribute.withArgs('bar').resolves(undefined)
+      fakeElement2.getAttribute.withArgs('bar').resolves(null)
       fakeClient.$$.withArgs('.some-selector').resolves([
         fakeElement1,
         fakeElement2,