Drop commons-codec as a dependency #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jchambers
force-pushed
the
drop_commons_codec
branch
2 times, most recently
from
104fe56 to
47ae5a4
Compare
|
Another option would be using base64 from java8. |
True! But then we'd have to drop support for Java 7, and I don't know that this is the thing that should push us over that line. |
|
Could be just a matter of optimizing efforts. |
|
I'm happy to discuss JVM support, but I think it probably makes sense to open a separate issue or mailing list thread. Seem legit? |
jchambers
force-pushed
the
drop_commons_codec
branch
from
47ae5a4 to
d81bff0
Compare
jchambers
force-pushed
the
drop_commons_codec
branch
from
d81bff0 to
b05776b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apache Commons Codec is a fine library that we were using for Base64 encoding/decoding for APNs signing/verification keys and authentication tokens. Even though it's a little more verbose, we can do the same thing with Netty's Base64 tools. Since we already depend on Netty, we can use that instead and have one less dependency to keep track of.