Don't treat internal server errors as write exceptions #576
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In days gone by, we wanted to treat upstream internal server errors as write exceptions instead of actual rejections. Two things have changed since we made that initial decision:
I propose removing that special-case handling and treating internal server errors just like any other rejection. The idea is that this would simplify things for end users by untangling which errors come from local/network problems and which errors come from the APNs server. What do you all think?
TODO: