Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't treat internal server errors as write exceptions #576

Merged
merged 1 commit into from
Apr 1, 2018

Conversation

jchambers
Copy link
Owner

@jchambers jchambers commented Jan 18, 2018

In days gone by, we wanted to treat upstream internal server errors as write exceptions instead of actual rejections. Two things have changed since we made that initial decision:

  1. Apple has fixed an upstream bug that used to cause a lot of internal server exceptions when using token-based authentication, so these are now very rare.
  2. Now that we have connection pooling, we have better means of addressing internal server errors (i.e. discarding unhealthy connections).

I propose removing that special-case handling and treating internal server errors just like any other rejection. The idea is that this would simplify things for end users by untangling which errors come from local/network problems and which errors come from the APNs server. What do you all think?


TODO:

  • Update docs

@jmason
Copy link

jmason commented Jan 18, 2018

That makes sense to me, 👍

@jchambers jchambers force-pushed the drop_exception_for_internal_server_error branch from b2d5c48 to 518107a Compare January 19, 2018 14:27
@jchambers jchambers added this to the v0.13.0 milestone Mar 27, 2018
@jchambers jchambers force-pushed the drop_exception_for_internal_server_error branch from 518107a to 164cb9e Compare April 1, 2018 16:38
@jchambers jchambers merged commit e6813a7 into master Apr 1, 2018
@jchambers jchambers deleted the drop_exception_for_internal_server_error branch April 1, 2018 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants