Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the "id" column for the table "casbin_rule". #24

Merged
merged 1 commit into from
Jan 22, 2021

Conversation

shy1st
Copy link
Contributor

@shy1st shy1st commented Jan 22, 2021

Fix: #21

@codecov
Copy link

codecov bot commented Jan 22, 2021

Codecov Report

Merging #24 (9670dcd) into master (b6525cb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #24   +/-   ##
=========================================
  Coverage     59.64%   59.64%           
  Complexity       93       93           
=========================================
  Files            16       16           
  Lines           394      394           
  Branches         39       39           
=========================================
  Hits            235      235           
  Misses          131      131           
  Partials         28       28           
Impacted Files Coverage Δ Complexity Δ
src/main/java/org/casbin/adapter/DB2Adapter.java 0.00% <ø> (ø) 0.00 <0.00> (ø)
src/main/java/org/casbin/adapter/JdbcAdapter.java 72.35% <ø> (ø) 30.00 <0.00> (ø)
...rc/main/java/org/casbin/adapter/OracleAdapter.java 0.00% <ø> (ø) 0.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6525cb...9670dcd. Read the comment docs.

@hsluoyz hsluoyz requested a review from fangzhengjin January 22, 2021 08:54
@hsluoyz
Copy link
Member

hsluoyz commented Jan 22, 2021

@fangzhengjin please review.

@hsluoyz
Copy link
Member

hsluoyz commented Jan 22, 2021

@wy10cheng @daiyueliang plz review.

Copy link
Contributor

@fangzhengjin fangzhengjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we consider checking the existing database and adding the id field to allow users of the old version to upgrade without hindrance?
Or do we issue an announcement on the impact of the upgrade?

@Moon-86
Copy link

Moon-86 commented Jan 22, 2021

Sorry,Could you also update casbin-spring-boot-starter.jar in maven repository ?
Thank you

@fangzhengjin
Copy link
Contributor

Sorry,Could you also update casbin-spring-boot-starter.jar in maven repository ?
Thank you

I do not understand what you mean.

@Moon-86
Copy link

Moon-86 commented Jan 22, 2021

Sorry,Could you also update casbin-spring-boot-starter.jar in maven repository ?
Thank you

I do not understand what you mean.

https://mvnrepository.com/artifact/org.casbin/casbin-spring-boot-starter
⇧Sorry,here don't need update?

@fangzhengjin
Copy link
Contributor

Sorry,Could you also update casbin-spring-boot-starter.jar in maven repository ?
Thank you

I do not understand what you mean.

https://mvnrepository.com/artifact/org.casbin/casbin-spring-boot-starter
⇧Sorry,here don't need update?

Need to update, but does this have anything to do with the issue we are discussing now?

@hsluoyz
Copy link
Member

hsluoyz commented Jan 22, 2021

Should we consider checking the existing database and adding the id field to allow users of the old version to upgrade without hindrance?
Or do we issue an announcement on the impact of the upgrade?

@shy1st whether do you think we need it?

@shy1st
Copy link
Contributor Author

shy1st commented Jan 22, 2021

Should we consider checking the existing database and adding the id field to allow users of the old version to upgrade without hindrance?
Or do we issue an announcement on the impact of the upgrade?

@shy1st whether do you think we need it?

I think we don't need it. We can issue an announcement on the impact of the upgrade.

@hsluoyz hsluoyz merged commit 9a3e75a into jcasbin:master Jan 22, 2021
@hsluoyz
Copy link
Member

hsluoyz commented Jan 22, 2021

@shy1st plz make a Maven & GitHub Release (or we can use your new semantic-release feature)

@shy1st
Copy link
Contributor Author

shy1st commented Jan 23, 2021

Excuse me,could you tell me what command you usually use to release the version to the maven repository for this project? @fangzhengjin

@fangzhengjin
Copy link
Contributor

fangzhengjin commented Jan 23, 2021

Excuse me,could you tell me what command you usually use to release the version to the maven repository for this project? @fangzhengjin

Modify the version_code in the gradle.properties file and tag it. After Travis is built, it will be published to bintray, and then you need to log in to bintray to synchronize to MavenCenter.

Excuse me,could you tell me what command you usually use to release the version to the maven repository for this project? @fangzhengjin

Modify the version_code in the gradle.properties file and tag it. After Travis is built, it will be published to bintray, and then you need to log in to bintray to synchronize to MavenCenter.

Thanks.

Try not to mark when you have not modified the version_code, because it may overwrite the build of the previous version of bintray.

@hsluoyz
Copy link
Member

hsluoyz commented Jan 23, 2021

@shy1st plz use English. Actually I don't know why the quoted content becomes Chinese :)

@shy1st
Copy link
Contributor Author

shy1st commented Jan 23, 2021

Excuse me,could you tell me what command you usually use to release the version to the maven repository for this project? @fangzhengjin

Modify the version_code in the gradle.properties file and tag it. After Travis is built, it will be published to bintray, and then you need to log in to bintray to synchronize to MavenCenter.

Thanks.

@shy1st
Copy link
Contributor Author

shy1st commented Jan 23, 2021

@shy1st plz use English. Actually I don't know why the quoted content becomes Chinese :)

Sorry, it was a mistake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no ‘id’ in casbin rule?
4 participants