-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the "id" column for the table "casbin_rule". #24
Conversation
Codecov Report
@@ Coverage Diff @@
## master #24 +/- ##
=========================================
Coverage 59.64% 59.64%
Complexity 93 93
=========================================
Files 16 16
Lines 394 394
Branches 39 39
=========================================
Hits 235 235
Misses 131 131
Partials 28 28
Continue to review full report at Codecov.
|
@fangzhengjin please review. |
@wy10cheng @daiyueliang plz review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we consider checking the existing database and adding the id field to allow users of the old version to upgrade without hindrance?
Or do we issue an announcement on the impact of the upgrade?
Sorry,Could you also update casbin-spring-boot-starter.jar in maven repository ? |
I do not understand what you mean. |
https://mvnrepository.com/artifact/org.casbin/casbin-spring-boot-starter |
Need to update, but does this have anything to do with the issue we are discussing now? |
@shy1st whether do you think we need it? |
I think we don't need it. We can issue an announcement on the impact of the upgrade. |
@shy1st plz make a Maven & GitHub Release (or we can use your new semantic-release feature) |
Excuse me,could you tell me what command you usually use to release the version to the maven repository for this project? @fangzhengjin |
Modify the version_code in the gradle.properties file and tag it. After Travis is built, it will be published to bintray, and then you need to log in to bintray to synchronize to MavenCenter.
Try not to mark when you have not modified the version_code, because it may overwrite the build of the previous version of bintray. |
@shy1st plz use English. Actually I don't know why the quoted content becomes Chinese :) |
Thanks. |
Sorry, it was a mistake. |
Fix: #21