Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RabbitMQ vars and version control #159

Closed
jpmjpmjpm opened this issue Aug 4, 2020 · 4 comments
Closed

RabbitMQ vars and version control #159

jpmjpmjpm opened this issue Aug 4, 2020 · 4 comments

Comments

@jpmjpmjpm
Copy link
Contributor

RabbitMQ vars overrides the ones defined in env_vars.

RabbitMQ variables of the playbook:

rabbitmq_server_name: "{{ inventory_hostname }}"
rabbitmq_admin_user: admin
rabbitmq_admin_password: password
rabbitmq_application_vhost: "{{ application_name }}"
rabbitmq_application_user: "{{ application_name }}"
rabbitmq_application_password: password

are defined in the env_vars/*.yml files as well as in the roles/rabbitmq/vars/main.yml file.

This is creating issues on my side as I use ansible-vault encrypt_string to encrypt rabbitmq password and those passwords are hosts dependent. This seems related to issues #111 and #64

Suggested fix (before solving issues mentioned in previous paragraph): remove roles/rabbitmq/vars/main.yml file.

What do you think?

Thanks for your feedbacks.

@YPCrumble
Copy link
Collaborator

@jpmjpmjpm related to this I think our playbook is stuck on version 3.6.15 of RabbitMQ as the debian repo has moved from the apt repository we're referencing. Have you had any issues with your RabbitMQ system? I just had mine stop working after a routine deployment that included some security upgrades on Ubuntu that seems to have broken that version of RabbitMQ.

@jpmjpmjpm
Copy link
Contributor Author

@YPCrumble I haven't notice issues yet with RabbitMQ, but will surely have. I indeed noticed that we're stuck with this old 3.6.15 version. I think that like for PostgreSQL, we should have variables controlling the installed version.

What do you think? I can have a look to it.

As a side comment, I have PR #169 and PR #156 which are still waiting for being merged. The last one since June. Any reason for this???

@jpmjpmjpm
Copy link
Contributor Author

jpmjpmjpm commented Dec 2, 2020

@jpmjpmjpm related to this I think our playbook is stuck on version 3.6.15 of RabbitMQ as the debian repo has moved from the apt repository we're referencing. Have you had any issues with your RabbitMQ system? I just had mine stop working after a routine deployment that included some security upgrades on Ubuntu that seems to have broken that version of RabbitMQ.

I created a PR in order to control RabbitMQ installed version. This ensures that a much recent version of RabbitMQ is installed. And also that an adequate version of Erlang is associated.

@jpmjpmjpm jpmjpmjpm changed the title Duplication of RabbitMQ vars RabbitMQ vars and version control Dec 2, 2020
jpmjpmjpm pushed a commit to jpmjpmjpm/ansible-django-stack that referenced this issue Dec 2, 2020
@YPCrumble
Copy link
Collaborator

Closed via #174

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants