Ensure image buffers passed to the worker spun to generate a PDF request is transferrable #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eokoneyo
commented
Jan 27, 2025
| } | ||
| } | ||
|
|
||
| myPort.postMessage(generatePdfRequest, this.transferList); |
There was a problem hiding this comment.
Since we ensure the buffers added to this list are transferable, it should be fine to simply pass them along. I wonder if after doing this we still need the former safe guard especially that we also have tests in place
eokoneyo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Modify implementation to add image to pdf creates new transferrable image buffer, so that buffers that get sent to reporting worker will always get detached and free up memory on the main thread.
Informed from https://github.com/elastic/kibana/pull/205983/files#r1929384942