Skip to content

Commit

Permalink
Always link generator frames when propagating a thrown-in exception t…
Browse files Browse the repository at this point in the history
…hrough a yield-from chain.
  • Loading branch information
jbower-fb committed Oct 28, 2024
1 parent 2544159 commit 0f26c06
Show file tree
Hide file tree
Showing 2 changed files with 30 additions and 7 deletions.
22 changes: 21 additions & 1 deletion Lib/test/test_generators.py
Original file line number Diff line number Diff line change
Expand Up @@ -758,7 +758,8 @@ def check_stack_names(self, frame, expected):
while frame:
name = frame.f_code.co_name
# Stop checking frames when we get to our test helper.
if name.startswith('check_') or name.startswith('call_'):
if (name.startswith('check_') or name.startswith('call_')
or name.startswith('test')):
break

names.append(name)
Expand Down Expand Up @@ -799,6 +800,25 @@ def call_throw(gen):

self.check_yield_from_example(call_throw)

def test_throw_with_yield_from_custom_generator(self):

class CustomGen:
def __init__(self, test):
self.test = test
def throw(self, *args):
self.test.check_stack_names(sys._getframe(), ['throw', 'g'])
def __iter__(self):
return self
def __next__(self):
return 42

def g(target):
yield from target

gen = g(CustomGen(self))
gen.send(None)
gen.throw(RuntimeError)


class YieldFromTests(unittest.TestCase):
def test_generator_gi_yieldfrom(self):
Expand Down
15 changes: 9 additions & 6 deletions Objects/genobject.c
Original file line number Diff line number Diff line change
Expand Up @@ -471,14 +471,11 @@ _gen_throw(PyGenObject *gen, int close_on_genexit,
return gen_send_ex(gen, Py_None, 1, 0);
goto throw_here;
}
PyThreadState *tstate = _PyThreadState_GET();
if (PyGen_CheckExact(yf) || PyCoro_CheckExact(yf)) {
/* `yf` is a generator or a coroutine. */
PyThreadState *tstate = _PyThreadState_GET();
/* Since we are fast-tracking things by skipping the eval loop,
we need to update the current frame so the stack trace
will be reported correctly to the user. */
/* XXX We should probably be updating the current frame
somewhere in ceval.c. */

/* Link frame into the stack to enable complete backtraces. */
_PyInterpreterFrame *prev = tstate->current_frame;
frame->previous = prev;
tstate->current_frame = frame;
Expand All @@ -502,10 +499,16 @@ _gen_throw(PyGenObject *gen, int close_on_genexit,
Py_DECREF(yf);
goto throw_here;
}

_PyInterpreterFrame *prev = tstate->current_frame;
frame->previous = prev;
tstate->current_frame = frame;
PyFrameState state = gen->gi_frame_state;
gen->gi_frame_state = FRAME_EXECUTING;
ret = PyObject_CallFunctionObjArgs(meth, typ, val, tb, NULL);
gen->gi_frame_state = state;
tstate->current_frame = prev;
frame->previous = NULL;
Py_DECREF(meth);
}
Py_DECREF(yf);
Expand Down

0 comments on commit 0f26c06

Please sign in to comment.