Reverse if order

jbossas · Sep 26, 2024 · 2cc0ffa · 2cc0ffa
1 parent 7931ae6
commit 2cc0ffa
Showing 1 changed file with 11 additions and 11 deletions.
diff --git a/src/main/java/org/jboss/threads/EnhancedQueueExecutor.java b/src/main/java/org/jboss/threads/EnhancedQueueExecutor.java
@@ -1688,7 +1688,17 @@ private QNode getOrAddNode(PoolThreadNode nextPoolThreadNode) {
                 // headNext == head can happen if another consumer has already consumed head:
                 // retry with a fresh head
                 if (headNext != head) {
-                    if (headNext instanceof TaskNode) {
+                    if (headNext instanceof PoolThreadNode || headNext == null) {
+                        nextPoolThreadNode.setNextRelaxed(headNext);
+                        if (head.compareAndSetNext(headNext, nextPoolThreadNode)) {
+                            return nextPoolThreadNode;
+                        } else if (headNext != null) {
+                            // GC Nepotism:
+                            // save dragging headNext into old generation
+                            // (although being a PoolThreadNode it won't make a big difference)
+                            nextPoolThreadNode.setNextRelaxed(null);
+                        }
+                    } else if (headNext instanceof TaskNode) {
                         TaskNode taskNode = (TaskNode) headNext;
                         if (compareAndSetHead(head, taskNode)) {
                             // save from GC Nepotism: generational GCs don't like
@@ -1699,16 +1709,6 @@ private QNode getOrAddNode(PoolThreadNode nextPoolThreadNode) {
                             if (getQueueLimited()) decreaseQueueSize();
                             return taskNode;
                         }
-                    } else if (headNext instanceof PoolThreadNode || headNext == null) {
-                        nextPoolThreadNode.setNextRelaxed(headNext);
-                        if (head.compareAndSetNext(headNext, nextPoolThreadNode)) {
-                            return nextPoolThreadNode;
-                        } else if (headNext != null) {
-                            // GC Nepotism:
-                            // save dragging headNext into old generation
-                            // (although being a PoolThreadNode it won't make a big difference)
-                            nextPoolThreadNode.setNextRelaxed(null);
-                        }
                     } else {
                         assert headNext instanceof TerminateWaiterNode;
                         return headNext;