Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for resolved symlinks in copytree #230

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

brno32
Copy link
Contributor

@brno32 brno32 commented Jul 19, 2023

Fixes #221

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Merging #230 (1cadb72) into master (b81d5f1) will decrease coverage by 0.08%.
The diff coverage is 92.85%.

@@            Coverage Diff             @@
##           master     #230      +/-   ##
==========================================
- Coverage   99.07%   98.99%   -0.08%     
==========================================
  Files          24       24              
  Lines        5085     5095      +10     
==========================================
+ Hits         5038     5044       +6     
- Misses         47       51       +4     
Flag Coverage Δ
98.99% <92.85%> (-0.08%) ⬇️
py3.10 98.95% <92.85%> (-0.08%) ⬇️
py3.11 ?
py3.7 98.94% <92.85%> (-0.08%) ⬇️
py3.8 ?
py3.9 98.97% <92.85%> (-0.10%) ⬇️
x64 98.95% <92.85%> (-0.12%) ⬇️
x86 98.99% <92.85%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/smbclient/shutil.py 95.53% <92.85%> (+0.20%) ⬆️

... and 2 files with indirect coverage changes

@jborean93
Copy link
Owner

Just an FYI the Samba target doesn't support symlinks so you'll need to only run the symlink tests on Windows.

@brno32 brno32 force-pushed the copytree-local-to-remote-with-symlinks branch 2 times, most recently from f3c0d02 to ae8e4f4 Compare July 19, 2023 21:16
@brno32 brno32 changed the title adding support for resolved symlinks for local to remote operations i… support for resolved symlinks in copytree Jul 19, 2023
@brno32 brno32 force-pushed the copytree-local-to-remote-with-symlinks branch 2 times, most recently from 38cb37e to baff1df Compare July 19, 2023 21:48
@brno32 brno32 marked this pull request as draft July 19, 2023 22:01
@brno32 brno32 force-pushed the copytree-local-to-remote-with-symlinks branch from baff1df to 13ccd47 Compare July 20, 2023 21:28
@brno32 brno32 force-pushed the copytree-local-to-remote-with-symlinks branch from 13ccd47 to 1cadb72 Compare July 20, 2023 21:32
@Neustradamus
Copy link

@brno32, @jborean93: Any progress on it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Additional features in shutil.py
3 participants