Migrate SSPI to external library #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #69 +/- ##
==========================================
- Coverage 99.96% 99.96% -0.01%
==========================================
Files 31 30 -1
Lines 5387 5357 -30
==========================================
- Hits 5385 5355 -30
Misses 2 2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
This commit adds a new dependency for Windows that includes the sspi bindings. This removes the extra Cython build step for Windows allowing it to be shipped as a pure wheel and simplifying our build steps. It also solves the problem with Cython 3 that our original Cython code was incompatible with. Finally it removes extra code allowing it to be tested in a more self contained library.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new dependency for Windows that includes the sspi bindings. This removes the extra Cython build step for Windows allowing it to be shipped as a pure wheel and simplifying our build steps. It also solves the problem with Cython 3 that our original Cython code was incompatible with. Finally it removes extra code allowing it to be tested in a more self contained library.