Added support for channel binding tokens when using HTTPS connections #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jborean93
added a commit
that referenced
this pull request
Oct 15, 2020
…#6) * Added support for channel binding tokens when using HTTPS connections
jborean93
added a commit
that referenced
this pull request
Oct 4, 2021
…#6) * Added support for channel binding tokens when using HTTPS connections
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if a WSMan target has set
Auth/CbtHardeningLevel = Strictthen OMI will fail to connect over HTTPS when using Negotiate/Kerberos. This is because the current code does not pass in the necessary structure to GSSAPI that binds the auth with the TLS channel that the CBT check is for.This PR retrieves the CBT data for GSSAPI if possible and makes sure it's passed into
gss_init_sec_contextif available. It also rejigs some of the SSL connection code in preparation for cert verification that I'm hoping to look into next.TODO: