-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit concurrency of remote file requests #50
Conversation
Use bluebird’s Promise.map() with concurrency option to limit HTTP requests when creating remote nodes for file attachments in order to avoid being rate-limited by Airtable’s HTTP servers.
More recent versions of Gatsby removed the global polyfill for Bluebird so that is likely why your tests are failing. There probably isn't really a better / native way to handle this so it might be worth just adding Bluebird as a dependency and explicitly using the imported function here (not the global polyfill). (Unless you have a better idea.) At minimum, I would ask that you add a comment in the code on "why this specific limit", but I'm wondering if maybe we make this configurable (with a reasonable default) since we are kind of shooting in the dark here it seems. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great, and we have a green build. Would you mind adding some brief documentation? Then I think we are all set to merge.
@jamessimone interested in reviewing since you looked before? Otherwise I'm happy with where this is at. Thanks again for taking this on @jonesbp! 🎉 |
@jonesbp I do have some feedback about the wording in the readme. I'm also happy to push a commit for this if you'd like. |
Tighten language in documentation
I have applied the suggested documentation edits. Thanks @jamessimone . |
Cheers! Thanks @jonesbp, published to v2.0.8. |
@jonesbp nice job! |
Hi folks, |
@rgesulfo oh, we didn't document it. It goes adjacent to the apiKey. |
Thanks @jbolda!
Because it still fails for me. |
Use bluebird’s Promise.map() with concurrency option to limit HTTP requests when creating remote nodes for file attachments in order to avoid being rate-limited by Airtable’s HTTP servers.