-
-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve readme and organize package.json #177
Conversation
I haven't had a chance to fully review, but I wanted to say thanks @grikomsn 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the markdown wraps coming from Prettier? I am fine switching it to wrapped text, but I would like something "standard" if we are going to do it.
"keywords": [ | ||
"gatsby", | ||
"gatsby-plugin", | ||
"gatsby-source", | ||
"gatsby-source-airtable", | ||
"airtable" | ||
], | ||
"license": "MIT" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a guide that you are using to sort these? I would expect these make most sense under author.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no guide for sorting the keywords
<!-- markdownlint-disable MD033 MD041 --> | ||
<div align="center"> | ||
|
||
![gatsby-source-airtable](./header.png) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lovely!
I manually wrapped it, but Prettier using Maybe adding |
I just don't want to manually wrap it from now and into the future 😄 . I just updated prettier if you wanted to merge in from master and add a command to take care of running prettier for us. |
Co-Authored-By: Jacob Bolda <me@jacobbolda.com>
Since there are new changes from upstream, I'll close this PR and create another from the latest upstream commits (#180). |
I think we could have taken care of it in this PR, but no worries. Do you plan to open another PR with the readme updates? 🙏 That logo was 🔥 . |
Definitely will create another PR after #180 is merged ✨ |
Hello there 👋🏻
Many thanks for the awesome plugin, thought I give back by updating the readme and a little bit of organizing the
package.json
structure for readability. Collapsible content below are image previews of the readme before and after updating.Screenshot preview
Let me know if there's anything I shoud revert or change.