forked from stepank/pyws
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add long simple type support.
- Loading branch information
Jean-Baptiste Lamotte
committed
Nov 22, 2013
1 parent
30dbe8d
commit 54e11fc
Showing
3 changed files
with
47 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 comment
on commit 54e11fc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you added a new data type, please, add some tests. You can use 14037e3 as an example. You can also look at these tests:
https://github.com/stepank/pyws/blob/develop/tests/python/suds/testcases/test_add_integers.py
https://github.com/stepank/pyws/blob/develop/tests/php/testcases/AddIntegersTest.php
https://github.com/stepank/pyws/blob/develop/tests/mono/testcases/AddIntegersTest.cs
https://github.com/stepank/pyws/blob/develop/tests/java/axis/testcases/AddIntegersTestCase.java
https://github.com/stepank/pyws/blob/develop/tests/python/rest/testcases/test_add_integers.py
Please, do not use this indentation style, the preferred style is:
If lines become longer than 79 symbols (pep8) because of this rule, then split them like this: