Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial commit to support world-clouds visualization #18

Merged
merged 2 commits into from
May 10, 2020

Conversation

selimelawwa
Copy link
Contributor

@selimelawwa selimelawwa commented May 10, 2020

closes #12
Basic implementation for word-clouds visualization
Add wordcloud to list of in "requirements.txt" file

@selimelawwa selimelawwa reopened this May 10, 2020
@selimelawwa selimelawwa mentioned this pull request May 10, 2020
@jbesomi jbesomi changed the title Initial commit to support word-clouds visualization Initial commit to support world-clouds visualization May 10, 2020
@jbesomi
Copy link
Owner

jbesomi commented May 10, 2020

Thank you Selim!

It may be opportune to have as input a pd.Series rather than a pd.Dataframe.

Also, for joining the text we may want to use:

>>> import pandas as pd
>>> s = pd.Series(["a", "b", "c"])
>>> s.str.cat(sep=' ')
'a b c'

Can you also add some unittest? You can look at the official world_cloud tests.

@selimelawwa
Copy link
Contributor Author

I have changed the function have as input a pd.Series @jbesomi .

Regarding unit tests. I have checked official world_cloud tests. However current implementation of the word cloud method would not allow for implementing similar tests. Maybe we can have an underlining method _get_world_cloud which gets the WordCloud object which we can then test for words ..etc?

Do we only need to test the words in the generated word cloud? What else would you want to test?

@jbesomi jbesomi merged commit c00f1dc into jbesomi:master May 10, 2020
@jbesomi
Copy link
Owner

jbesomi commented May 10, 2020

Thank you. Closing for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wordclouds
2 participants