Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleaned up regex function by introducing constants for patterns #143

Draft
wants to merge 20 commits into
base: master
Choose a base branch
from
Draft

cleaned up regex function by introducing constants for patterns #143

wants to merge 20 commits into from

Conversation

mk2510
Copy link
Collaborator

@mk2510 mk2510 commented Aug 6, 2020

cleaned up all regex functions and removed the new clean pipeline

Maximilian Krahn and others added 15 commits July 26, 2020 22:49
@henrifroese
Speed up default clean function
3ab14fd 
speeded up the default function, by writing it in just one and let it operate on strings


Co-authored-by: Henri Froese <hf2000510@gmail.com>
@mk2510 @henrifroese
Regex pattern to constancs
e0f02c5 
removed the regex pattern from the functions and placed them in an constant above



Co-authored-by: Henri Froese <hf2000510@gmail.com>
@mk2510 @henrifroese
changed clean function docstring
2ea3caf 
changed Docstring



Co-authored-by: Henri Froese <hf2000510@gmail.com>
@mk2510
removed default pipeline for cleaning
697a229
@mk2510
added unittest for the clean function
4bb9860
@mk2510
format file
57c37c1
@mk2510
added unit test for clean function
db4934e
@mk2510
updated naming schema
5887485
@mk2510
improved comment on helper function _get_pattern_for_tokenasiton()
addc23b
@mk2510
fixed spelling mistake
84652ee
@mk2510
Merge remote-tracking branch 'upstream/master' into speed_up_preproce…
3e7056b 
…ssing
@mk2510
fixed some merge conflicts
16b775f
@mk2510
Merge remote-tracking branch 'upstream/master' into speed_up_preproce…
0b41020 
…ssing
@mk2510
rm optimised clean
af66252
@mk2510 @henrifroese
inserted old clean
7ab3a38 
inserted the old cleaning pipeline



Co-authored-by: Henri Froese <hf2000510@gmail.com>
@henrifroese henrifroese added the enhancement New feature or request label Aug 6, 2020
@jbesomi jbesomi marked this pull request as draft August 7, 2020 15:15
@jbesomi jbesomi requested a review from henrifroese August 7, 2020 15:15
henrifroese
henrifroese requested changes Aug 7, 2020
View reviewed changes
Copy link
Collaborator

@henrifroese henrifroese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall, just a few small comments. preprocessing.py will look much nicer if this is merged.

texthero/preprocessing.py Outdated Show resolved Hide resolved
texthero/preprocessing.py Outdated Show resolved Hide resolved
texthero/preprocessing.py Outdated Show resolved Hide resolved
@mk2510 mk2510 marked this pull request as ready for review August 8, 2020 09:44
jbesomi
jbesomi reviewed Aug 8, 2020
View reviewed changes
tests/test_preprocessing.py Outdated Show resolved Hide resolved
jbesomi
jbesomi reviewed Aug 8, 2020
View reviewed changes
texthero/preprocessing.py Outdated Show resolved Hide resolved
@jbesomi
Copy link
Owner

jbesomi commented Aug 8, 2020

  • you need to fix some conflicts

@vercel vercel bot temporarily deployed to Preview August 8, 2020 18:53 Inactive
@mk2510
Copy link
Collaborator Author

mk2510 commented Aug 10, 2020

you need to fix some conflicts

I have fixed those. The problem was just, that the series types were introduced in the file. 🤖

@jbesomi jbesomi marked this pull request as draft September 14, 2020 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbesomi jbesomi jbesomi left review comments

@henrifroese henrifroese henrifroese approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mk2510 @jbesomi @henrifroese