Refactor output parsing #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbergstroem
force-pushed
the
feat/problem-matcher
branch
from
5a0d4b1 to
3649169
Compare
Instead of parsing JSON output from hadolint, we now read `-f tty`. This removes the depency of `jq`. Also, refactor how output buffers are managed, making it more suitable for both reviewing github workflows manually as well as how output variables are set (also, avoiding the now deprecated `::set-output` in favor of `$GITHUB_OUTPUT`.
This makes it easier to konw what version you're running in programatically
jbergstroem
force-pushed
the
feat/problem-matcher
branch
from
3649169 to
b4ba976
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes so far:
Todo:
Elsewhere (set up as part of landing this):
Fixes: #88
Fixes: #78
Closes: #3