Don't use segment hashCode in MemorySegmentVectorFloat, as it depends…

… on segment base/offset in the heap rather than contents. This breaks testing around PQVectors hashcodes.
jbellis · Dec 3, 2024 · 90e84a9 · 90e84a9
1 parent e2a4ad1
commit 90e84a9
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 2 deletions.
diff --git a/jvector-base/src/main/java/io/github/jbellis/jvector/vector/ArrayVectorFloat.java b/jvector-base/src/main/java/io/github/jbellis/jvector/vector/ArrayVectorFloat.java
@@ -114,7 +114,7 @@ public boolean equals(Object o)
     @Override
     public int hashCode()
     {
-        return Arrays.hashCode(data);
+        return this.getHashCode();
     }
 }
 
diff --git a/jvector-base/src/main/java/io/github/jbellis/jvector/vector/types/VectorFloat.java b/jvector-base/src/main/java/io/github/jbellis/jvector/vector/types/VectorFloat.java
@@ -40,4 +40,14 @@ default int offset(int i) {
     void set(int i, float value);
 
     void zero();
+
+    default int getHashCode() {
+        int result = 1;
+        for (int i = 0; i < length(); i++) {
+            if (get(i) != 0) {
+                result = 31 * result + Float.hashCode(get(i));
+            }
+        }
+        return result;
+    }
 }
diff --git a/jvector-native/src/main/java/io/github/jbellis/jvector/vector/MemorySegmentVectorFloat.java b/jvector-native/src/main/java/io/github/jbellis/jvector/vector/MemorySegmentVectorFloat.java
@@ -130,6 +130,6 @@ public boolean equals(Object o)
 
     @Override
     public int hashCode() {
-        return segment.hashCode();
+        return this.getHashCode();
     }
 }