Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic Row Height #13

Closed
jasonlfunk opened this issue Jan 23, 2017 · 2 comments
Closed

Dynamic Row Height #13

jasonlfunk opened this issue Jan 23, 2017 · 2 comments
Assignees

Comments

@jasonlfunk
Copy link

Is there a way to have the row height be updated dynamically? I assumed that I just just pass the argument a data attribute, but it doesn't seem to be reactive to the data changing.

@jasonlfunk
Copy link
Author

Ah, I see. The rowHeight in the GridItem is set once in the mounted() event by manually reading it from the parent. I see that the props were commented out. Is there a reason it was done this way?

@gmsa
Copy link
Contributor

gmsa commented Jan 24, 2017

It was mostly a quick hack to get it working without having to supply extra props to the GridItems. It should be changed to be updated from the parent with events. I'll do it when I have some free time.

@gmsa gmsa self-assigned this Feb 1, 2017
gmsa added a commit that referenced this issue Feb 9, 2017
@gmsa gmsa closed this as completed Feb 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants