Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double resolve #1553

Merged
merged 3 commits into from
Feb 2, 2023
Merged

Fix double resolve #1553

merged 3 commits into from
Feb 2, 2023

Conversation

quintesse
Copy link
Contributor

@quintesse quintesse commented Jan 31, 2023

When running a previously built app jbang would sometimes resolve artifacts twice

When runing a previously built app jbang would sometimes resolve twice
Jbang now prints out which artifacts were out of date and why when
comparing dependencies against the cache,
@codecov
Copy link

codecov bot commented Feb 1, 2023

Codecov Report

Base: 0.00% // Head: 0.00% // No change to project coverage 👍

Coverage data is based on head (64564f4) compared to base (66c9f3a).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1553   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files        121     121           
  Lines       7378    7385    +7     
  Branches    1199    1199           
=====================================
- Misses      7378    7385    +7     
Flag Coverage Δ
Linux 0.00% <0.00%> (ø)
Windows 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...n/java/dev/jbang/dependencies/DependencyCache.java 0.00% <0.00%> (ø)
...in/java/dev/jbang/dependencies/DependencyUtil.java 0.00% <ø> (ø)
src/main/java/dev/jbang/source/Project.java 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@maxandersen maxandersen merged commit 7b978e0 into jbangdev:main Feb 2, 2023
@quintesse quintesse deleted the fix_double_resolve branch February 2, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants