Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #1531 #1547

Merged
merged 1 commit into from
Jan 30, 2023
Merged

issue #1531 #1547

merged 1 commit into from
Jan 30, 2023

Conversation

kanha-gupta
Copy link
Contributor

Bug fix
-Build was successful
-native command would work now

#1531

Copy link
Contributor

@quintesse quintesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

quintesse
quintesse previously approved these changes Jan 27, 2023
@quintesse
Copy link
Contributor

To be completely perfect and ready to merge, could you perhaps change the wording of your commit to something like:

fix: Alias command now properly sets nativeImage

fixes #1531

and repush? (using --force to overwrite your previous commit)

@codecov
Copy link

codecov bot commented Jan 27, 2023

Codecov Report

Base: 0.00% // Head: 0.00% // No change to project coverage 👍

Coverage data is based on head (8fded1f) compared to base (41012eb).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1547   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files        121     121           
  Lines       7377    7378    +1     
  Branches    1199    1199           
=====================================
- Misses      7377    7378    +1     
Flag Coverage Δ
Linux 0.00% <0.00%> (ø)
Windows 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/main/java/dev/jbang/cli/Alias.java 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kanha-gupta
Copy link
Contributor Author

@quintesse Please check, i've edited commit message.

@maxandersen maxandersen merged commit 66c9f3a into jbangdev:main Jan 30, 2023
@quintesse
Copy link
Contributor

Perfect, thanks @kanha-gupta !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants