Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use blocking method rather than the throwing one #744

Merged
merged 1 commit into from
Mar 10, 2022

Conversation

pzygielo
Copy link
Contributor

@pzygielo pzygielo commented Jan 5, 2022

Avoid:
Exception in thread Thread-7 java.lang.IllegalStateException: Queue full
        at java.base/java.util.AbstractQueue.add(AbstractQueue.java:98)
        at java.base/java.util.concurrent.ArrayBlockingQueue.add(ArrayBlockingQueue.java:326)
        at org.jbake.maven.util.DirWatcher.onUpdated(DirWatcher.java:57)
        at org.jbake.maven.util.DirWatcher.accessbash00(DirWatcher.java:17)
        at org.jbake.maven.util.DirWatcher.onFileChange(DirWatcher.java:40)
        at org.apache.commons.io.monitor.FileAlterationObserver.doMatch(FileAlterationObserver.java:410)
        at org.apache.commons.io.monitor.FileAlterationObserver.checkAndNotify(FileAlterationObserver.java:333)
        at org.apache.commons.io.monitor.FileAlterationObserver.checkAndNotify(FileAlterationObserver.java:334)
        at org.apache.commons.io.monitor.FileAlterationObserver.checkAndNotify(FileAlterationObserver.java:303)
        at org.apache.commons.io.monitor.FileAlterationMonitor.run(FileAlterationMonitor.java:183)
        at java.base/java.lang.Thread.run(Thread.java:829)
which stops further processing of changed files.
@pzygielo pzygielo marked this pull request as ready for review January 6, 2022 09:58
@pzygielo

This comment was marked as outdated.

1 similar comment
@pzygielo
Copy link
Contributor Author

pzygielo commented Mar 9, 2022

May I ask for review, please?

@jonbullock
Copy link
Member

Apologies @pzygielo for the delay and thanks for contributing. 👍

@jonbullock jonbullock added this to the v2.7.0 milestone Mar 10, 2022
@jonbullock jonbullock merged commit ac58d7e into jbake-org:master Mar 10, 2022
@pzygielo pzygielo deleted the queue branch March 10, 2022 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IllegalStateException in maven plugin :watch goal
2 participants