Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All jbake-core dependencies are forced on you when used in another Maven project #437

Closed
jonbullock opened this issue Mar 22, 2018 · 3 comments
Assignees
Labels
Milestone

Comments

@jonbullock
Copy link
Member

Dependencies that provide content format support and template engine support were optional prior to 2.6.0 but are now forced on you when you include jbake-core in a project (as jbake-maven-plugin does) so you can't include just the dependencies that you require (i.e. include Freemarker but not Groovy).

Had a quick search and came across this: gradle/gradle#867

@jonbullock jonbullock added this to the v2.6.1 milestone Mar 22, 2018
@jonbullock jonbullock self-assigned this Mar 22, 2018
@manikmagar
Copy link
Member

Could that be the reason for binary file size difference? 2.6.0 download size is 69MB, compared to 2.5.1 having 40MB only.

@ancho
Copy link
Member

ancho commented Mar 22, 2018

ah. honestly I wasn't aware of the optional maven dependencies while switching to gradle. so the nebula plugin seems the way to go.

as for the size difference. we had a few dependency changes since 2.5.1. asciidoctorj-diagram and felxmark (as replacement for pegdown).

See directory and file sizes for 2.5.1 and 2.6.0 and the dependency graph

We could replace flexmark-all with a minimal set of dependencies we really need. We don't need all extensions and converters.

@jonbullock
Copy link
Member Author

I'd completely forgotten about it... only noticed as I'm updating my example projects that use the plugins for a talk and forgot to include the other dependencies and thought to myself how is it even baking a site without them being declared.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants