Set type: module in package.json #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @Avnerus - agreed that this change is needed, thanks for the pull request! |
|
Thank you! Could you also publish to npm? |
|
@Avnerus 1.0.2 has been now published to npm, if you see any other issues with this release just let me know. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Adding
"type": "module"topackage.jsoninstructs Node applications to load the package as an ES-Module. It is now supported by default since Node 10 reached its end of life.This makes it easier to write test applications that use
three-volumetric-4dviewsas pure ES Modules. Especially useful since three.js switched to native ES6 modules in r127, and cannot be loaded into node without some serious transpilation. Three.JS also uses"type": "module", for example here.Thank you!
/Avner