better write stream

[calvinmetcalf]

great module, but the write stream doesn't quite follow the conventions of a regular write stream, this fixes it to make sure it acts like a normal write stream, I was having some issues where it would look like it was done but the data wasn't written yet

[jb55]

we removed this awhile back #5,#7 since we'd rather use the official stream upload implementation from aws-sdk. Perhaps there is a way to fix the issue you're referring to without the additional dependency?

[calvinmetcalf]

the issue is just that since you have that proxy stream in the way, that one ends before it's actually done uploading and looking back through the aws skd it doesn't look like they expose a real stream

[calvinmetcalf]

would it be helpful if I made a test that fails without this pull but succeeds with it to demonstrate the issue better ?

[jb55]

I'll just push a new major version. Those who are happy with the current behaviour can stay on 1.*

[jb55]

available at 2.0.1

[calvinmetcalf]

woot thanks!

…

On Mon, Jun 19, 2017 at 11:30 AM William Casarin ***@***.***> wrote: available at 2.0.1 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#13 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABE4n5zDuezqNEsmeN6Pez0hqM46Z68Yks5sFpQqgaJpZM4N6ODP> .