Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

apps using torchbear interpreter should read torchbear.scl config file from "app-dir" #196

Open
naturallymitchell opened this issue Jan 2, 2019 · 4 comments
Open

apps using torchbear interpreter should read torchbear.scl config file from "app-dir" #196

naturallymitchell opened this issue Jan 2, 2019 · 4 comments
Labels
progress/1

Comments

@naturallymitchell
Copy link
Member

No description provided.

@naturallymitchell naturallymitchell changed the title when running a torchbear app in another torchbear app when running a torchbear app in another torchbear app's dir, don't check current dir's torchbear.scl for init.lua Jan 2, 2019
@dariusc93
Copy link
Contributor

Could you provide clarification?

@naturallymitchell
Copy link
Member Author

if you're working on gut, for example, and you run mp inside the dir, then torchbear will look for a torchbear.scl file in gut/. that behavior was meant for it to work in the machu-picchu/ directory though, so this is an unexpected behavior.

@naturallymitchell naturallymitchell changed the title when running a torchbear app in another torchbear app's dir, don't check current dir's torchbear.scl for init.lua apps using torchbear interpreter shoudl read torchbear.scl config file from " Jan 12, 2019
@naturallymitchell naturallymitchell changed the title apps using torchbear interpreter shoudl read torchbear.scl config file from " apps using torchbear interpreter shoudl read torchbear.scl config file from "app-dir" Jan 12, 2019
@naturallymitchell naturallymitchell changed the title apps using torchbear interpreter shoudl read torchbear.scl config file from "app-dir" apps using torchbear interpreter should read torchbear.scl config file from "app-dir" Jan 12, 2019
dariusc93 added a commit that referenced this issue Jan 12, 2019
@dariusc93
Change current directory to path of application
7b80aee 
Since torchbear isnt setting a directory, it will show it is running from whatever directory it is called from and affecting its ability to read things like scl, etc.

Related to #196
@naturallymitchell
Copy link
Member Author

that commit broke mp, because it needs to run in current_dir

@naturallymitchell naturallymitchell mentioned this issue Jan 13, 2019
Closed
@naturallymitchell
Copy link
Member Author

fixed in 7b80aee#diff-b4aea3e418ccdb71239b96952d9cddb6 and 9b5d825#diff-b4aea3e418ccdb71239b96952d9cddb6 afair

@naturallymitchell naturallymitchell mentioned this issue Feb 10, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
progress/1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@naturallymitchell @dariusc93