-
-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support django 4.2 new STORAGES format #728
Conversation
Thanks! Would you also like to suggest a PR which adds Django 4.2 in the testing matrix? |
done! I updated test.yaml and tox.ini, not sure if it is enough |
Codecov Report
@@ Coverage Diff @@
## master #728 +/- ##
==========================================
+ Coverage 73.70% 73.76% +0.06%
==========================================
Files 30 30
Lines 1696 1700 +4
==========================================
+ Hits 1250 1254 +4
Misses 446 446
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Any clue about the test failures? |
@claudep looking at the tests, they failed with Strange that I did not modify any behaviour there, I just added python 3.11 and django 4.2 to the test matrix. I made one typo which I just pushed a fix, but I don't believe it would be that. Either way, can you approve the tests to run again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now!
By the way, I think we should move the THUMBNAIL_STORAGE
setting to a key from the STORAGES
dict, so we can get the storage directly from the django.core.files.storage.storages
structure. Would you like to continue working on this?
Sure!Can you open an issue for that and assign it to me, so that I don't forget it? =P |
Done with #729, but I cannot assign you (don't ask me why, GitHub mystery). |
Fix #716