Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
safe_filter
is currently applied in a way which results in the functions actually executed on template rendering not being decorated.Old example
New example after merging this PR:
Order of old example resulted in
register.filter
being called on the actual functionis_portrait
and the result of this than being decorated bysafe_filter
. Changing order ensures that a withsafe_filter
decoratedis_portrait
is registered as template filter.The commit 2260492 demonstrates this by just extending the tests to show the failure. Commit after this fixes it.
Please consider applying this :-)