Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase thumbnail management command on BaseCommand #686

Merged
merged 1 commit into from
Feb 12, 2022

Conversation

claudep
Copy link
Contributor

@claudep claudep commented Feb 5, 2022

Using LabelCommand as base was adding more complexity than necessary.

@codecov
Copy link

codecov bot commented Feb 5, 2022

Codecov Report

Merging #686 (01fbb4d) into master (4fcb55d) will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #686      +/-   ##
==========================================
+ Coverage   73.70%   73.75%   +0.05%     
==========================================
  Files          30       30              
  Lines        1700     1688      -12     
==========================================
- Hits         1253     1245       -8     
+ Misses        447      443       -4     
Impacted Files Coverage Δ
sorl/thumbnail/management/commands/thumbnail.py 100.00% <100.00%> (+7.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fcb55d...01fbb4d. Read the comment docs.

Using LabelCommand as base was adding more complexity than necessary.
@camilonova camilonova merged commit 49c124e into jazzband:master Feb 12, 2022
@claudep claudep deleted the command branch February 12, 2022 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants