Fix compatibility with pip master (pip>=20.0) #978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moved `RequirementPreparer.session` to `Resolver.session`. See pypa/pip#7290
|
@vphilippon |
Codecov Report
@@ Coverage Diff @@
## master #978 +/- ##
==========================================
+ Coverage 99.31% 99.31% +<.01%
==========================================
Files 34 34
Lines 2346 2350 +4
Branches 303 305 +2
==========================================
+ Hits 2330 2334 +4
Misses 8 8
Partials 8 8
Continue to review full report at Codecov.
|
See details in jazzband#953 (comment)
2 tasks
atugushev
commented
Nov 4, 2019
| @@ -219,8 +223,7 @@ def resolve_reqs(self, download_dir, ireq, wheel_cache): | |||
| if PIP_VERSION < (19, 4): | |||
| resolver.require_hashes = require_hashes | |||
| results = resolver._resolve_one(reqset, ireq) | |||
| else: # pragma: no cover | |||
| # TODO remove pragma after pip==19.4 being released | |||
There was a problem hiding this comment.
FTR, this change addressed to #953 (comment).
codingjoe
approved these changes
Nov 6, 2019
|
@codingjoe thanks! |
atugushev
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved
RequirementPreparer.sessiontoResolver.session. See pypa/pip#7290Failed job: https://github.com/jazzband/pip-tools/commit/4dee581f2603e21271e9c7b38830507ed749357b/checks?check_suite_id=294004753
Changelog-friendly one-liner: Add compatibility with
pip>=20.0.Contributor checklist
Provided the tests for the changes.