-
-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing OutputWriter._iter_lines for pip 8.1.1 or below #540
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could yo add a test in tests/test_writer.py:
Similar to test_format_requirement_environment_marker
, but with a package such as test_foo
, and the output being test-foo
and the marker is kept.
You can skip the CHANGELOG entry.
I'm totally willing to add a test, but I don't understand what you want to test here ? My change is in Also this aims to fix a compatibility issue with pip 8.1.1 or below, so maybe the best way to test it would be to add a |
You're right, I was under the impression that the formatting was changed, but it's actually the value passed that might be different. That would be a different test. Adding a test suite in tox using Also, sorry for the delay, life happened. Thank you for your time! |
I added a test tox env, |
@Lucas-C You also have to add the new |
No problem: done ! |
Thanks for your contribution! |
Thanks for your help :) |
Contributor checklist
An existing test ensures this does not introduces any regression: https://github.com/jazzband/pip-tools/blob/master/tests/test_writer.py
I don't think this is needed as it is a fix.
Nope. Anyone please ? :)