Fix resolver when toplevel requirements are also in pinned subdependency #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidovich
force-pushed
the
fix_resolver_when_presented_with_same_pinned_dependency
branch
from
8759212
to
95f7141
Compare
suutari-ai
added a commit
to suutari/prequ
that referenced
this pull request
Feb 9, 2017
This merges PR jazzband#450 and fixes jazzband#449. * pip-tools-integration: Change log: Add entry about merged resolver fix Fix resolver when toplevel requirements are also in pinned subdependency
suutari-ai
added a commit
to suutari/prequ
that referenced
this pull request
Feb 9, 2017
Mark the merged PRs of pip-tools in Change Log more clearly so that it is easier to keep track which fixes/features are already in. This includes following 7 PRs: * jazzband#355 * jazzband#378 * jazzband#389 * jazzband#417 * jazzband#441 * jazzband#448 * jazzband#450
davidovich
deleted the
fix_resolver_when_presented_with_same_pinned_dependency
branch
|
I created a fake package as is mentioned in the steps to reproduce the problem, and carefully traced pip-compile both before and after @davidovich's patch, and I can confirm that it indeed solves a real (and subtle) issue. |
|
Fixes #384 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The itertools.broupby() usage introduced a subtle change that caused the self.our_constraints to be rewritten with wrong expectations, causing the resolver to fail.
Fixes #449