Check the pip version is compatible ASAP #429
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If running an out-of-date version of pip, it's possible to hit an ImportError while doing package-internal imports. This means we never hit the compatibility check, and a nasty traceback is printed to the console. See #428 for one such example. This patch runs the compatibility checks as soon as we import pip, which minimises the risk of an unhelpful error message.
alexwlchan
commented
Dec 21, 2016
|
|
||
| # Make sure we're using a compatible version of pip | ||
| from ..utils import assert_compatible_pip_version | ||
| assert_compatible_pip_version() |
There was a problem hiding this comment.
There is still a possibility of error if an ImportError is thrown in utils.py, but the fix for that is more destructive, and would mean moving this function into its own file. I don’t mind doing that, but I’ll wait to see if reviewers think that would be necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids getting a nasty traceback if we hit an error between importing pip and running the compatibility check.
Additionally, it seems like the supported version of pip was incremented but the README wasn’t. This patch fixes the README.
I considered adding a test for this, but that would require an entirely new set of tests for what is hopefully an edge case scenario.
Resolves #484.