Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure canonicalized requirement names are used as keys, to prevent unnecessary reinstallations during sync #1572

Merged
merged 2 commits into from
Feb 7, 2022
Merged

Ensure canonicalized requirement names are used as keys, to prevent unnecessary reinstallations during sync #1572

merged 2 commits into from
Feb 7, 2022

Commits on Feb 5, 2022

  1. Ensure key_from_req returns consistent canonicalized names 

    Fixes jazzband#1570

Remove assert:
- assert doesn't belong in non-test code
- if key's not a str, canonicalize should fail
    @AndydeCleyre
    AndydeCleyre committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    82089c8 View commit details
    Browse the repository at this point in the history

  2. add test_key_from_ireq_normalization 

    Based on jazzband#1570
    @AndydeCleyre
    AndydeCleyre committed Feb 5, 2022
    Configuration menu
    Copy the full SHA
    b7c3466 View commit details
    Browse the repository at this point in the history