Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pypi.py #1559

Closed
wants to merge 6 commits into from
Closed

Update pypi.py #1559

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c26600f
Update pypi.py
fsecada01 Jan 30, 2022
ca615c3
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 30, 2022
f568224
Update pypi.py
fsecada01 Jan 31, 2022
ba72b6e
Update pypi.py
fsecada01 Feb 2, 2022
a515723
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Feb 2, 2022
d579142
Update setup.cfg
fsecada01 Feb 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions piptools/repositories/pypi.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -450,17 +450,17 @@ def _setup_logging(self) -> None:

# Sync pip's console handler stream with LogContext.stream
logger = logging.getLogger()
for handler in logger.handlers:
if handler.name == "console": # pragma: no branch
assert isinstance(handler, logging.StreamHandler)
handler.stream = log.stream
break
else: # pragma: no cover
logger_names = [x.name for x in logger.handlers]
if "console" not in logger_names: # pragma: no cover
# There is always a console handler. This warning would be a signal that
# this block should be removed/revisited, because of pip possibly
# refactored-out logging config.
log.warning("Couldn't find a 'console' logging handler")

else:
for handler in logger.handlers:
if isinstance(handler, logging.StreamHandler):
handler.stream = log.stream
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while this is expected to suppress the error, this would lead to not assigning log.stream to the relevant handler anymore as it's now a different type

break
# Sync pip's progress bars stream with LogContext.stream
for bar_cls in itertools.chain(*BAR_TYPES.values()):
bar_cls.file = log.stream
Expand Down