Fixed typing #1408
Merged
Fixed typing #1408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
webknjaz
reviewed
Jun 2, 2021
asottile
reviewed
Jun 2, 2021
|
I think we should ignore the coverage issue as covering for both versions of click 7 and 8 would make our CI pipelines too complex. It is just one line not covered. It would be much easier to just bump minimal version of click required than covering for both versions. |
webknjaz
reviewed
Jun 3, 2021
webknjaz
reviewed
Jun 3, 2021
|
It is needed to pass mypy because the type changed in click 8 vs 7. |
pip 21.0 has internal changes that break at least our typing and we will need signifiant changes to support 21.x. For the moment we ceil pip version and assure running mypy does get us consistent results inside and outside pre-commit. Fixes type change introduced by click 8
webknjaz
approved these changes
Jun 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog-friendly one-liner: Fixed typing
Contributor checklist
pip 21.0 has internal changes that break at least our typing and we will need significant changes to support 21.x for typing. For the moment we ceil pip version for mypy and assure running mypy does get us consistentresults inside and outside pre-commit.
Fixes type change introduced by click 8
A previous version of this patch attempted to pin down pip version in setup.cfg but I soon found that piplatest tox env
started to fail as
in-tree-buildfeature was unknown to it. I suppose we will have to bump minimal pip version requiredto >=21 as soon we upgrade type hints .