-
-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix failing tox tests #1405
fix failing tox tests #1405
Conversation
…nd using newest feature in new version
Codecov Report
@@ Coverage Diff @@
## master #1405 +/- ##
=======================================
Coverage 99.67% 99.67%
=======================================
Files 33 34 +1
Lines 3038 3040 +2
Branches 327 327
=======================================
+ Hits 3028 3030 +2
Misses 5 5
Partials 5 5
Continue to review full report at Codecov.
|
tox.ini
Outdated
pipprevious: pip==20.3.* | ||
piplatest: pip | ||
pipmain: -e git+https://github.com/pypa/pip.git@main#egg=pip | ||
pip20.3: pip==20.3.* | ||
setenv = | ||
coverage: PYTEST_ADDOPTS=--strict --doctest-modules --cov --cov-report=term-missing --cov-report=xml {env:PYTEST_ADDOPTS:} | ||
pipprevious,pip20.3: PIP_DISABLE_PIP_VERSION_CHECK=1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
those are probably not necessary - should we still use them anyways (at least the feature flag)?
@@ -11,12 +11,15 @@ extras = | |||
testing | |||
coverage: coverage | |||
deps = | |||
setuptools<57 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This requires a comment explaining the motivation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added a comment
Closes #1403 .
Changelog-friendly one-liner: fix failing tox tests by pinning setuptools to old version and disabling pip version check on old version and using new feature "in-tree-build" in new version
Contributor checklist