Fix a bug where pip-compile would keep outdated options #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consider a test case: $ cat requirements.in --find-links foo $ cat requirements.txt --find-links bar The bug was that pip-compile would keep both options from requirements.in and requirements.txt: $ pip-compile --no-header --find-links foo --find-links bar It should keep the options from requirements.in file: $ pip-compile --no-header --find-links foo The fix is to pass a temporary finder, session, and options instances to parse_requirements() when parsing an existing requirements.txt file.
Closed
Codecov Report
@@ Coverage Diff @@
## master #1029 +/- ##
=========================================
+ Coverage 99.11% 99.5% +0.38%
=========================================
Files 34 34
Lines 2370 2418 +48
Branches 302 306 +4
=========================================
+ Hits 2349 2406 +57
+ Misses 11 6 -5
+ Partials 10 6 -4
Continue to review full report at Codecov.
|
|
@vphilippon thanks for reviewing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1018.
Consider a test case:
The bug was that pip-compile would keep both options from requirements.in and requirements.txt:
It should keep the options from requirements.in file:
The fix is to pass a temporary finder, session, and options instances to
parse_requirements()when parsing an existing requirements.txt.Changelog-friendly one-liner: Fix a bug where
pip-compilewould keep outdated options fromrequirements.txt.Contributor checklist