Fix magic with arguments that have a dash #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow users to do magic with an argument like --arg-name and convert it to args.arg_name
Codecov Report
@@ Coverage Diff @@
## master #6 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 490 490
=====================================
Hits 490 490
Continue to review full report at Codecov.
|
|
screaming sorry - 2019 was a mess, and it legit took me until half through 2021 to get online again. Thanks for the PR! Merged! |
|
oh dang, welcome back! No worries, I'm just glad it's in!! I may support/submit a few others now as well, thanks for the help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to be able to support arguments that look like this:
-a --argument-name This is the argument to testThis PR enables dot access as before but converts the name to
arguments.argument_name.