Django 4.2.0 and Python 3.11 compatibility #484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tox throws up a warning that this external file cannot be run without being in the allowed externals list and then does not run the tests.
clintonb
approved these changes
Apr 13, 2023
Closed
|
Python 3.7 has reached its EOL https://devguide.python.org/versions/#unsupported-versions. Please can we have new release after this PR is merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR doesn't change any of the underlying library code, it just runs the tests against Django 4.2 and Python 3.11 (for supported Django versions, 4.1 and 4.2).
The commit adding
run.shtoallowlist_externalswas required to get the tests running undertoxand given that it's something I've had to implement before figured it was probably important enough to include. Though it is surprising that it's not been an issue for anyone else...This should presumably be enough to close #483 and #411