Set realistic code coverage target. #185
Conversation
| @@ -3,7 +3,7 @@ coverage: | |||
| status: | |||
| patch: | |||
| default: | |||
| target: 95 | |||
| target: 75 | |||
| project: | ||
| default: | ||
| target: 83 | ||
| target: 75 |
There was a problem hiding this comment.
should not be less then 80 IMHO
There was a problem hiding this comment.
I agree that it should be as high as possible. Ideally.
The situation at present - in the last ticket we had coverage at 76.31%. If we set it higher (e.g. 80%) then all PRs will automatically fail (except those specifically targeted at increasing coverage).
My concern is that people will get into a habit of ignoring the code coverage test - "it always fails, just ignore it".
It could be described as a "Normalization of deviance" situation, and the long term effect would be that drops in coverage would be missed.
Re. your suggestion to set the figure at 80 - I don't think it will make any change to the current situation, and it negates the goal of this PR.
|
@clintonb this can be closed IMHO, with test coverage now being at 95%. |
The CI runs a check on code coverage. At present we are nowhere near the target and all recent PRs have failed this check.
I suggest reducing the % so that current PRs pass. This way we still check that PRs do not reduce coverage.
In future if someone wants to put a lot of TLC into this project, we can increase the values :-)