Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicated TestStringReference class #105

Closed
nemesifier opened this issue Mar 28, 2017 · 2 comments
Closed

Duplicated TestStringReference class #105

nemesifier opened this issue Mar 28, 2017 · 2 comments

Comments

@nemesifier
Copy link
Contributor

It looks like there is a duplicated TestStringReference class.

I think the piece of code I just linked is not being executed currently.

Possible solutions would be:

  1. rename it
  2. delete it
@rohithasrk
Copy link
Contributor

rohithasrk commented Mar 28, 2017 •
edited
Loading

Renaming would be better option IMO. As it runs the same tests on another model named 'Store'

nemesifier added a commit to nemesifier/django-sortedm2m that referenced this issue Mar 28, 2017
@nemesifier
Renamed duplicated TestStringReference classes jazzband#105
8eeac22 
Fixes jazzband#105
@nemesifier nemesifier mentioned this issue Mar 28, 2017
Merged
@nemesifier
Copy link
Contributor Author

nemesifier commented Mar 28, 2017 •
edited
Loading

@rohithasrk tried renaming it and it's good to go, opened PR #106

gregmuellegger added a commit that referenced this issue Aug 1, 2017
@gregmuellegger
Merge pull request #106 from nemesisdesign/issues/105
8d61c3b 
Renamed duplicated TestStringReference classes #105
rohithasrk added a commit to rohithasrk/django-sortedm2m that referenced this issue Aug 2, 2017
@rohithasrk
Update from sorted2m/master (#1)
c86e958 
* Support Django up to 1.11, fix DeprecationWarnings

Also set warnings to raise as errors in unit tests to prevent
regressions that re-introduce the warnings.

* Renamed duplicated TestStringReference classes jazzband#105

Fixes jazzband#105

* Add changelog for 1.4.0 release

* Bump version to 1.4.0

* Prepare new dev version

* Adding missing link to jazzband#104 in changelog

* Fixes jazzband#96: Improve string representation of sortedm2m relationships
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nemesifier @rohithasrk