Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle case-insensitive sensitive headers #674

Merged
merged 3 commits into from
Sep 11, 2023
Merged

Conversation

shtimn
Copy link
Contributor

@shtimn shtimn commented Sep 8, 2023

fixes #673

@shtimn shtimn marked this pull request as ready for review September 8, 2023 10:08
silk/model_factory.py Outdated Show resolved Hide resolved
silk/model_factory.py Show resolved Hide resolved
@shtimn shtimn force-pushed the master branch 2 times, most recently from 2424cb7 to 128188a Compare September 8, 2023 11:55
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Merging #674 (d573d5a) into master (25b3191) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #674      +/-   ##
==========================================
- Coverage   86.51%   86.50%   -0.01%     
==========================================
  Files          52       52              
  Lines        2091     2090       -1     
==========================================
- Hits         1809     1808       -1     
  Misses        282      282              
Files Changed Coverage Δ
silk/model_factory.py 84.47% <100.00%> (-0.08%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shtimn
Copy link
Contributor Author

shtimn commented Sep 8, 2023

Hi @albertyw,

I have made some improvements to the handling of sensitive headers in the RequestModelFactory.encoded_headers method.
Could you please take a moment to review the changes ?

Thanks!

@albertyw albertyw merged commit 9c2aba2 into jazzband:master Sep 11, 2023
@shtimn
Copy link
Contributor Author

shtimn commented Sep 12, 2023

@albertyw, I appreciate the merge 😊

Could you please let me know when the new version is scheduled?

@albertyw
Copy link
Member

New version will be released with #678

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SILKY_HIDE_COOKIES does not hide cookie header in different case
3 participants