Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add inspectdb test #95

Merged
merged 1 commit into from
Feb 16, 2022
Merged

add inspectdb test #95

merged 1 commit into from
Feb 16, 2022

Conversation

shimizukawa
Copy link
Member

Feature or Bugfix

  • Feature & Bugfix

Purpose

Relates

@codecov
Copy link

codecov bot commented Feb 16, 2022

Codecov Report

Merging #95 (f33c35d) into master (58981ac) will increase coverage by 1.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
+ Coverage   51.42%   52.44%   +1.01%     
==========================================
  Files           3        3              
  Lines         280      286       +6     
  Branches       79       80       +1     
==========================================
+ Hits          144      150       +6     
  Misses        125      125              
  Partials       11       11              
Impacted Files Coverage Δ
django_redshift_backend/base.py 49.62% <100.00%> (+1.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58981ac...f33c35d. Read the comment docs.

Comment on lines +1 to +2
# copy AS-IS from django repository at stable/3.2.x
# https://github.com/django/django/blob/754af45/tests/migrations/test_base.py
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

copy AS-IS from django repository at stable/3.2.x
https://github.com/django/django/blob/754af45/tests/migrations/test_base.py

@@ -178,175 +177,3 @@ def test_sqlmigrate(self):
sql_statements = collect_sql(plan)
print('\n'.join(sql_statements))
assert sql_statements # It doesn't matter what SQL is generated.


class IntrospectionTest(unittest.TestCase):
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved to test_inspectdb.py

@shimizukawa shimizukawa merged commit 392a096 into jazzband:master Feb 16, 2022
@shimizukawa shimizukawa deleted the dev/inspectdb-test branch February 16, 2022 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant