Compatibility with Django 3

[xavier-lr]

Context removed since Django 3

Subject: Avoid errors of missing argument 'context'

Feature or Bugfix

• Bugfix

Purpose

• Avoid following error on Django 3:
  convert_uuidfield_value() missing 1 required positional argument: 'context'

Detail

• You can reproduce the issue setting UUID field on Django 3, saving the object and then loading it again.

Relates

• None

[shimizukawa]

Thanks!

I checked the history of this problem to validate the fix.
First, the convert_uuidfield_value was introduced in PR #24, around the time of Django-1.11. Postgres supports the uuid type, but Redshift treats it as a string. This django-redshift-backend is based on the postgres backend, so it doesn't have uuid support. I guess the PR #24 is based on MySQL's uuid support code: https://github.com/django/django/blob/1.11/django/db/backends/mysql/operations.py#L242-L245

At the same time, the context argument was removed from Django itself on django/django#8709 then this fix is reflected in Django 2.0. This means that anyone using the uuid type in django-redshift-backend after Django 2.0 was affected (I was not using the uuid type).

Thanks for the nice fix!

[shimizukawa]

Please remove context argument completely because context has been removed since django 2.0 and django-redshift-backend already drop support django 1.x.

[xavier-lr]

context removed !

[shimizukawa]

LGTM!

[codecov]

Codecov Report

Merging #80 (a88efdf) into master (d15682d) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master      #80   +/-   ##
=======================================
  Coverage   47.01%   47.01%           
=======================================
  Files           3        3           
  Lines         251      251           
  Branches       62       62           
=======================================
  Hits          118      118           
  Misses        123      123           
  Partials       10       10           

Impacted Files	Coverage Δ
django_redshift_backend/base.py	43.40% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d15682d...a88efdf. Read the comment docs.

[shimizukawa]

I'm going to release 2.1.0 in this week.

[shimizukawa]

Released! https://pypi.org/project/django-redshift-backend/2.1.0/