Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let users choose between psycopg2 binary or source #69

Merged
merged 2 commits into from
Nov 8, 2020

Conversation

browniebroke
Copy link
Member

@browniebroke browniebroke commented Nov 4, 2020

Subject: Let users choose between psycopg2 binary or source

Feature or Bugfix

  • Bugfix

Purpose

On our system we want to install the source version of psycopg2, but because of #60, we are also getting the binary version when we install django-redshift-backend.

Adding extra_requires to let the use choose which version they want.

Quoting the psycopg2 documentation:

If you are the maintainer of a published package depending on psycopg2 you shouldn’t use psycopg2-binary as a module dependency. For production use you are advised to use the source distribution.

Relates

Copy link
Member

@shimizukawa shimizukawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shimizukawa shimizukawa merged commit 44ed75f into jazzband:master Nov 8, 2020
@browniebroke browniebroke deleted the psycopg2-source branch November 8, 2020 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants