Merge pull request #138 from jazzband/pr/kylie-sre/133-1

[#132] use 36 length for UUIDFields to support including hyphens
jazzband · Jul 22, 2024 · 1bd2d44 · 1bd2d44
2 parents 0653dd8 + 1649ab4
commit 1bd2d44
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/CHANGES.rst b/CHANGES.rst
@@ -18,6 +18,7 @@ Features:
 * #83 Drop Django-2.2 support.
 * #134 Support adding COLUMN with UNIQUE; adding column without UNIQUE then add UNIQUE CONSTRAINT.
 * #135 Support adding BinaryField.
+* #132 Use 36 length for UUIDFields to support including hyphens. Thanks to kylie.
 
 Bug Fixes:
 

diff --git a/django_redshift_backend/base.py b/django_redshift_backend/base.py
@@ -1105,7 +1105,7 @@ def remove_field(self, model, field):
     "AutoField": "integer identity(1, 1)",
     "BigAutoField": "bigint identity(1, 1)",
     "TextField": "varchar(max)",  # text must be varchar(max)
-    "UUIDField": "varchar(32)",  # redshift doesn't support uuid fields
+    "UUIDField": "varchar(36)",  # redshift doesn't support uuid fields
     "BinaryField": "varbyte(%(max_length)s)",
 }
 

diff --git a/tests/test_redshift_backend.py b/tests/test_redshift_backend.py
@@ -25,7 +25,7 @@ def test_load_redshift_backend(self):
     "id" integer identity(1, 1) NOT NULL PRIMARY KEY,
     "ctime" timestamp with time zone NOT NULL,
     "text" varchar(max) NOT NULL,
-    "uuid" varchar(32) NOT NULL
+    "uuid" varchar(36) NOT NULL
 )
 ;''')