Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert 1070 (Celery tasks.py) #1126

Merged
merged 2 commits into from
Mar 19, 2022
Merged

Revert 1070 (Celery tasks.py) #1126

merged 2 commits into from
Mar 19, 2022

Conversation

n2ygk
Copy link
Member

@n2ygk n2ygk commented Mar 19, 2022

Fixes #1114
Fixes #1123

Description of the Change

#1070 was apparently not tested (and was not supplied with a test case). It could never have worked and also has since been flagged as conflicting with Huey's auto-discovery which also uses tasks.py.

A future PR might come which will document how to configure a Celery clear_tokens task.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@n2ygk n2ygk requested a review from a team March 19, 2022 18:37
@codecov
Copy link

codecov bot commented Mar 19, 2022

Codecov Report

Merging #1126 (1a821e0) into master (fc291ce) will increase coverage by 0.26%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1126      +/-   ##
==========================================
+ Coverage   96.59%   96.86%   +0.26%     
==========================================
  Files          32       31       -1     
  Lines        1794     1789       -5     
==========================================
  Hits         1733     1733              
+ Misses         61       56       -5     

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc291ce...1a821e0. Read the comment docs.

@n2ygk n2ygk mentioned this pull request Mar 19, 2022
5 tasks
Copy link
Member

@Andrew-Chen-Wang Andrew-Chen-Wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

recommendation: Add the function to a utils file and describe how to use it in the docs and docstring.

@n2ygk
Copy link
Member Author

n2ygk commented Mar 19, 2022

recommendation: Add the function to a utils file and describe how to use it in the docs and docstring.

I've added a new Tutorial in #1128 that addresses this.

@n2ygk n2ygk merged commit 2212144 into jazzband:master Mar 19, 2022
@n2ygk n2ygk deleted the revert_1070 branch March 19, 2022 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency on celery lacks documentation
2 participants