feat(monitor): Change default to None when the field is nullable #576
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I recently came across a non-intuitive behavior, IMHO. The
MonitorField
has its default value set tonow
even though marked as nullable. Please, I'm open to hearing the opinion case it's is expected behavior.Solution
After catching up the discussion in #100 I decided to implement it. The discussed solution is to set its default value to
None
whennull=True
.If might break backward compatibility the edge case of someone marking the field as
null=True
and not expecting default to be None.Commandments
CHANGES.rst
file to describe the changes, and quote according issue withGH-<issue_number>
.