fix: only fire the post_log signal when the log is created or when there is an error #561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hramezani should we expose |
Codecov Report
@@ Coverage Diff @@
## master #561 +/- ##
==========================================
+ Coverage 94.96% 94.98% +0.02%
==========================================
Files 31 31
Lines 994 998 +4
==========================================
+ Hits 944 948 +4
Misses 50 50
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
hramezani
reviewed
Sep 6, 2023
CHANGELOG.md
Outdated
| @@ -7,6 +7,7 @@ | |||
| #### Improvements | |||
|
|
|||
| #### Fixes | |||
| * only fire the `post_log` signal when the log is created or when there is an error in the process. | |||
There was a problem hiding this comment.
Suggested change
| * only fire the `post_log` signal when the log is created or when there is an error in the process. | |
| - fix: Only fire the `post_log` signal when the log is created or when there is an error in the process. |
hramezani
previously approved these changes
Sep 6, 2023
|
Thanks @aqeelat for the path 🙏 I only left a suggestion. Other than that, LGTM 👍
Not for now |
|
@hramezani then I guess we shouldn't pass it to the post_log signal? |
yes, let's not pass it for now. |
aqeelat
force-pushed
the
536-custom-signal-post_log-is-triggered-even-when-logentry-is-not-created
branch
from
5e2327d to
21c90eb
Compare
hramezani
approved these changes
Sep 7, 2023
|
Thanks @aqeelat |
aqeelat
deleted the
536-custom-signal-post_log-is-triggered-even-when-logentry-is-not-created
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #536